From 0a561324532d71967ec37c2aeff1924099576c22 Mon Sep 17 00:00:00 2001 From: Grant Birkinbine Date: Fri, 19 Mar 2021 08:02:29 -0700 Subject: [PATCH] cleanup and review suggestions - makefile and links Signed-off-by: Grant Birkinbine --- nginx-wsgi-flask/Makefile | 7 ------- nginx-wsgi-flask/README.md | 6 +----- nginx-wsgi-flask/docker-compose.yaml | 2 -- 3 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 nginx-wsgi-flask/Makefile diff --git a/nginx-wsgi-flask/Makefile b/nginx-wsgi-flask/Makefile deleted file mode 100644 index 9083d69..0000000 --- a/nginx-wsgi-flask/Makefile +++ /dev/null @@ -1,7 +0,0 @@ -make build: - - echo "[#] Killing old docker processes" - docker-compose rm -fs - - echo "[#] Building docker containers" - docker-compose up --build -d diff --git a/nginx-wsgi-flask/README.md b/nginx-wsgi-flask/README.md index 8ec9b7f..dd7c910 100644 --- a/nginx-wsgi-flask/README.md +++ b/nginx-wsgi-flask/README.md @@ -37,11 +37,7 @@ The compose file defines an application with two services `nginx-proxy` and `fla When deploying the application, docker-compose maps port 80 of the web service container to port 80 of the host as specified in the file. Make sure port 80 on the host is not being used by another container, otherwise the port should be changed. -## Build with Makefile (easy) - -Simply run `make build` to create the NGINX and Flask containers with `docker-compose`. You may also follow the steps below to use `docker-compose` natively. - -## Deploy with docker-compose (still easy) +## Deploy with docker-compose ```bash $ docker-compose up -d diff --git a/nginx-wsgi-flask/docker-compose.yaml b/nginx-wsgi-flask/docker-compose.yaml index 4d9a28c..00a4c56 100644 --- a/nginx-wsgi-flask/docker-compose.yaml +++ b/nginx-wsgi-flask/docker-compose.yaml @@ -9,8 +9,6 @@ services: - FLASK_SERVER_ADDR=flask-app:8000 ports: - "80:80" - links: - - flask-app depends_on: - flask-app healthcheck: